Query: Adds new QueryFeature and QueryInfo fields for embedding parameters#5875
Merged
Conversation
📝 Changelog reminder (non-blocking)This PR touches shipped source but does not appear to update the Touched (and missing entry for):
How to decideUse the rubric in
This check is non-blocking — merge is not gated on it. The |
yaoce-YC
approved these changes
May 18, 2026
khdang
approved these changes
May 18, 2026
adityasa
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the plumbing required for the upcoming
GenerateEmbeddingsquery feature, which lets the gateway return query plans that contain parameterized embeddings (used by hybrid search).Changes:
QueryFeature.cs— adds a newGenerateEmbeddings = 1 << 17flag to the internalQueryFeaturesenum so the SDK can advertise / detect support for embedding-parameterized query plans.QueryInfo.cs— adds a newEmbeddingParameterMap(Dictionary<string, string>, serialized asembeddingParameterMapwithNullValueHandling.Ignore) and aHasEmbeddingParametersconvenience accessor on the internalQueryInfomodel so query plans containing the new field round-trip correctly. Existing query plans without the field deserialize unchanged.QueryPartitionProviderTests.cs— adds two new cases toTestPartitionedQueryExecutionInfoDeserialization:QueryInfoplan with anembeddingParameterMap, validating the new field round-trips throughQueryPartitionProvider.ConvertPartitionedQueryExecutionInfo.HybridSearchQueryInfoplan whose componentQueryInfos each carry anembeddingParameterMap, validating the field round-trips when nested inside hybrid-search component query infos.SA1507.No public API surface change — both
QueryFeaturesandQueryInfoare internal in the released package. NoSupportedQueryFeaturesbitmask is flipped in this PR, so there is no behavior change for existing customer workloads on upgrade.Type of change
Closing issues
N/A
Changelog
### Unreleasedinchangelog.mdfor the user-facing impact of this change.If the second box is checked, briefly justify here: